php drupal-check.phar modules/contrib/media_entity_pinterest/
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------- 
  Line   media_entity_pinterest.install                         
 ------ ------------------------------------------------------- 
  14     Call to deprecated function file_prepare_directory().  
  25     Call to deprecated function file_unmanaged_copy().     
 ------ ------------------------------------------------------- 

 ------ ------------------------------------------------------------------------- 
  Line   tests/src/Unit/ConstraintsTest.php                                       
 ------ ------------------------------------------------------------------------- 
  49     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase.  
 ------ ------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors
CommentFileSizeAuthor
#14 3074751-14.patch852 byteschr.fritsch
#11 3074751-11.patch1.24 KBchr.fritsch
#7 3074751-7.patch1.12 KBgg4
#6 3074751-6.patch2.28 KBgg4
#5 3074751-5.patch1.99 KBchr.fritsch
#4 3074751-4.patch2.25 KBsahana _n
#2 deprecated-3074751-2.patch1.78 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3074751-2.patch1.78 KB

Please review.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Needs work

One more deprecation:

------ ---------------------------------------------------------------------
Line media_entity_pinterest.install
------ ---------------------------------------------------------------------
16 Call to deprecated function file_scan_directory():
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
------ ---------------------------------------------------------------------

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new 3074751-4.patch2.25 KB

Please review the patch. I removed deprecated methods

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3074751-5.patch1.99 KB

This only contains 8.7. deprecations and is ready to commit.

gg4’s picture

gg4 commented
StatusFileSize
new 3074751-6.patch2.28 KB

Need to add a version dependency as well.

gg4’s picture

gg4 commented
StatusFileSize
new 3074751-7.patch1.12 KB

Subsequent patch that contains 8.8. deprecations.

 ------ ---------------------------------------------------------------------
  Line   media_entity_pinterest.install
 ------ ---------------------------------------------------------------------
  18     Call to deprecated function file_scan_directory():
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
 ------ ---------------------------------------------------------------------

  • bonus committed 71e2219 on 8.x-2.x 
    Issue #3074751 by Sergiu Stici, chr.fritsch, Sahana _N, bonus:...
gg4’s picture

gg4 commented
Status: Reviewed & tested by the community » Needs review
gg4’s picture

gg4 commented
Status: Needs review » Postponed

Postponing the last piece of this. Would rather not add a dependency to the 8.x-2.x branch on 8.8 until 8.7 is no longer receiving security updates. See: https://www.drupal.org/core/release-cycle-overview

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Postponed » Needs review
StatusFileSize
new 3074751-11.patch1.24 KB

So I think it's time to get this done. The other media modules are also already D9 compatible and dropped D8.7 support in their latest releases.

For us it's important to get this at least committed to the dev branch, to build our distribution with composer.

  • bonus committed 87ba18b on 8.x-2.x authored by chr.fritsch 
    Issue #3074751 by bonus, chr.fritsch, Sergiu Stici, Sahana _N:...
gg4’s picture

gg4 commented
Status: Needs review » Fixed

Committed #11 to 8.x-2.x.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Fixed » Needs review
StatusFileSize
new 3074751-14.patch852 bytes

One error sneaked in...

  • bonus committed f7b8ccf on 8.x-2.x 
    Issue #3074751 by chr.fritsch, bonus: Deprecated Code Report
gg4’s picture

gg4 commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.