Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Aug 2019 at 06:35 UTC
Updated:
1 Sep 2019 at 17:59 UTC
Jump to comment: Most recent
Comments
Comment #2
pinesh commentedComment #3
vuilThank you for the contribution!
Added a Pareview link into the issue summary.
(1.) Remove all
.DS_Storefiles from your repository.(2.) Update your README.txt file as the following requirements: https://www.drupal.org/node/2181737
DrupalPractice has found some issues with your code.
(3.)
(4.)
(5.) There are also many issues into js/callup.js code.
Comment #4
avpadernoThank you for applying!
In addition to what reported in the previous comment, 8.x-1.x-dev is a wrong branch name; the correct branch name would be 8.x-1.x. The wrong branch needs to be removed.
Comment #5
pinesh commentedComment #6
avpadernoAlso 8.x-1.0 is a wrong branch name, and it should be removed.
Comment #7
avpadernoComment #8
pinesh commentedThank you @ilchovuchkov and @kiamlaluno for the quick reply!
@kiamlaluno please check branch name.
Comment #9
pinesh commentedComment #10
vuilThank you for the contribution!
I have not found any security related issues into the code.
Please be patience through the whole security review process.
Thank you again.
Comment #11
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.