When configuring Entity Share Cron, when checking a remote, the channel list is not loaded.

There is an error somewhere in the SettingsForm class.

Currently not blocking because you can do in two steps:

  1. checking a remote and saving
  2. then checking the channels in the remote and saving
CommentFileSizeAuthor
#6 settings-form-first-check-3073837-6.patch571 bytesid.rem.dev

Comments

Grimreaper created an issue. See original summary.

julien_g’s picture

julien_g commented
Assigned: Unassigned » julien_g
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: julien_g » Unassigned
id.aleks’s picture

id.aleks commented
Issue tags: +LutskGCW20
id.rem.dev’s picture

id.rem.dev commented
Assigned: Unassigned » id.rem.dev
id.rem.dev’s picture

id.rem.dev commented
Assigned: id.rem.dev » Unassigned
Status: Active » Needs review
StatusFileSize
new settings-form-first-check-3073837-6.patch571 bytes

Seems like the issue was a little tricky.
Please review.

id.aleks’s picture

id.aleks commented
Status: Needs review » Reviewed & tested by the community

@Vladimirrem nice catch .Thanks.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented 
+++ b/src/Form/SettingsForm.php
@@ -100,7 +100,7 @@ class SettingsForm extends ConfigFormBase {
+        '#prefix' => "<div id='channels-{$remote_id}' class='channels-container'>",

Thanks!!!

Oh, it was when during application of Drupal standard that this was introduced.

I have tested, it is ok.

Just a question, why {$remote_id} and not $remote_id only?

id.rem.dev’s picture

id.rem.dev commented

According to PHP.net there are some tricks and using {$var} is the most correct way. See here

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks @Vladimirrem!

I read the link you point to, and I have one last question/remark:

+++ b/src/Form/SettingsForm.php
@@ -100,7 +100,7 @@ class SettingsForm extends ConfigFormBase {
+        '#prefix' => "<div id='channels-{$remote_id}' class='channels-container'>",

According to the link in comment 9, Should it be ${remote_id} instead of {$remote_id} ?

id.aleks’s picture

id.aleks commented

@Grimreaper Actually it will produce the same result, because {} will be removed. As for me using {$remote_id} is more preferable instead of ${remote_id}. In the first case, it's more obvious that this is variable.

  • Vladimirrem authored 9de9019 on 8.x-2.x 
    Issue #3073837 by Vladimirrem, Grimreaper, id.aleks: Settings form:...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Reviewed & tested by the community » Fixed

Ok. Thanks for your replies!

Good for me, the patch is now merged!

Thanks for your help.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Fix credit attribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.