Problem/Motivation

This is a follow up to #2994699: Create a CKEditor plugin to select and embed a media item from the Media Library, and is blocked on that issue.

In #2994699-49: Wim Leers gave steps to reproduce a bug with the DrupalMediaLibrary CKEditor button's interaction with the "undo" button:

Steps to reproduce:

  1. Go to /node/add/article
  2. Click the "Insert from Media Library" button without giving focus to anything in CKEditor first
  3. Select media, insert it

Expected: Undo button is active.
Actual: It is not active.

If before step 2 you click inside the CKEditor iframe instance, or for example type something first, then the undo button does work as expected.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3073294-11.patch1.05 KBwim leers

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: [PP-1] Undo bug when first inserting media into unfocused CKEditor. » Undo bug when first inserting media into unfocused CKEditor

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Media Initiative, +Needs manual testing
Related issues: +#2994699: Create a CKEditor plugin to select and embed a media item from the Media Library

I cannot reproduce this anymore. Can somebody else?

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed (maintainer needs more info)

.

tanubansal’s picture

tanubansal commented

Same .. Can't reproduce

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: +Triaged Media Initiative issue
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Undo bug when first inserting media into unfocused CKEditor » Remove obsolete @todo for "Undo bug when first inserting media into unfocused CKEditor"
Version: 9.1.x-dev » 9.3.x-dev
Status: Closed (cannot reproduce) » Needs review
StatusFileSize
new 3073294-11.patch1.05 KB

We should still delete the @todo from Drupal core that points here :)

init90’s picture

init90
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 11c0e0a609 to 9.3.x and 80435fc747 to 9.2.x. Thanks!

  • alexpott committed 11c0e0a on 9.3.x 
    Issue #3073294 by Wim Leers, oknate: Remove obsolete @todo for "Undo bug...

  • alexpott committed 80435fc on 9.2.x 
    Issue #3073294 by Wim Leers, oknate: Remove obsolete @todo for "Undo bug...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.