| Comment | File | Size | Author |
|---|---|---|---|
| #9 | context-cannot-clone-context-3072991-9.patch | 6.44 KB | balis_m |
| #7 | 3072991-7.patch | 8.92 KB | strozx |
| #6 | 3072991-6.patch | 5.3 KB | strozx |
| #5 | 3072991-5.patch | 5.61 KB | nace_fr |
| #4 | 3072991-4.patch | 8.92 KB | bzoks |
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | context-cannot-clone-context-3072991-9.patch | 6.44 KB | balis_m |
| #7 | 3072991-7.patch | 8.92 KB | strozx |
| #6 | 3072991-6.patch | 5.3 KB | strozx |
| #5 | 3072991-5.patch | 5.61 KB | nace_fr |
| #4 | 3072991-4.patch | 8.92 KB | bzoks |
Comments
Comment #2
arnaldopComment #3
strozx commentedHi I have implemented this but it needs to be reviewed.
Comment #4
bzoks commentedI tested patch from #3, it works as expected, but I still did some minor adjustments to it:
- I renamed "clone" to "duplicate", to be in-line with Core naming of such feature.
- function name clone() is not valid before PHP 7, but D8 works also on PHP 5.6
- I replaced usage of deprecated drupal_set_message in new file. It is still present in other files.
Comment #5
nace_fr commentedTested the patch from #4, which works as expected, but I replaced usage of deprecated drupal_set_message in patch files.
Comment #6
strozx commentedReverted back to bzoks patch because patch 3072991-5 had some changes that are not part of this issue.
Comment #7
strozx commentedUpon further inspection there is a file missing in the last patch
Comment #8
nace_fr commentedI have checked my patch again and comment from strozx is correct. My patch had changes not part of this issue.
Patch from #4 is the correct one and now also patch on #7 as they are the same.
Comment #9
balis_m commentedPatch from #7 doesn' t apply to the current dev version. So, I rerolled it.
Comment #11
deaom commentedThe re-rolled patch applies to the latest dev branch and is still working as before/expected, So marking this as RTBC as the tests are not actually failing.
Comment #12
paulocsFeature will be added to the next release.
Thanks @all.
Comment #14
paulocs