Comments

arnaldop created an issue. See original summary.

arnaldop’s picture

Title: Cloning context » Can't clone context
Issue summary: View changes
strozx’s picture

Status: Active » Needs review
StatusFileSize
new8.67 KB

Hi I have implemented this but it needs to be reviewed.

bzoks’s picture

StatusFileSize
new8.92 KB

I tested patch from #3, it works as expected, but I still did some minor adjustments to it:
- I renamed "clone" to "duplicate", to be in-line with Core naming of such feature.
- function name clone() is not valid before PHP 7, but D8 works also on PHP 5.6
- I replaced usage of deprecated drupal_set_message in new file. It is still present in other files.

nace_fr’s picture

StatusFileSize
new5.61 KB

Tested the patch from #4, which works as expected, but I replaced usage of deprecated drupal_set_message in patch files.

strozx’s picture

StatusFileSize
new5.3 KB

Reverted back to bzoks patch because patch 3072991-5 had some changes that are not part of this issue.

strozx’s picture

StatusFileSize
new8.92 KB

Upon further inspection there is a file missing in the last patch

nace_fr’s picture

Status: Needs review » Reviewed & tested by the community

I have checked my patch again and comment from strozx is correct. My patch had changes not part of this issue.
Patch from #4 is the correct one and now also patch on #7 as they are the same.

balis_m’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new6.44 KB

Patch from #7 doesn' t apply to the current dev version. So, I rerolled it.

Status: Needs review » Needs work

The last submitted patch, 9: context-cannot-clone-context-3072991-9.patch, failed testing. View results

deaom’s picture

Status: Needs work » Reviewed & tested by the community

The re-rolled patch applies to the latest dev branch and is still working as before/expected, So marking this as RTBC as the tests are not actually failing.

paulocs’s picture

Feature will be added to the next release.
Thanks @all.

  • paulocs committed d3bd732 on 8.x-4.x authored by balis_m
    Issue #3072991 by strozx, nace_fric, bzoks, balis_m, arnaldop, paulocs,...
paulocs’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.