------ ----------------------------------------------------------------------
Line src/Controller/DownloadController.php
------ ----------------------------------------------------------------------
58 Call to deprecated function file_prepare_directory():
in Drupal 8.7.0, will be removed before Drupal 9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
73 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
78 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

[ERROR] Found 3 errors

CommentFileSizeAuthor
#4 download_all_files-d9_deprecated_code-3072758-4.patch3.42 KBvatsalkhanna
#2 daf-3072758-1.patch2.49 KBrudranil29

Comments

joy29 created an issue. See original summary.

rudranil29’s picture

rudranil29 commented
StatusFileSize
new daf-3072758-1.patch2.49 KB

patch for drupal 9 compatibility

rudranil29’s picture

rudranil29 commented
Assigned: rudranil29 » Unassigned
Status: Active » Needs review
vatsalkhanna’s picture

vatsalkhanna commented
StatusFileSize
new download_all_files-d9_deprecated_code-3072758-4.patch3.42 KB

drupal-check on branch 8.x-1.x

Found below issues:

------ --------------------------------------------------------------------------------------------------------------------- 
  Line   src/Controller/DownloadController.php                                                                                
 ------ --------------------------------------------------------------------------------------------------------------------- 
  30     PHPDoc tag @param has invalid value ($field_name                                                                     
         Node file field name.): Unexpected token "$field_name", expected type at offset 136                                  
  30     PHPDoc tag @param has invalid value ($node_id                                                                        
         Node id.): Unexpected token "$node_id", expected type at offset 99                                                   
  58     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use  
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.                                                             
  58     Call to deprecated function file_prepare_directory():                                                                
         in drupal:8.7.0 and is removed from drupal:9.0.0.                                                                    
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().                                                       
  73     Call to deprecated function drupal_set_message():                                                                    
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                                                    
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.                                                 
  78     Call to deprecated function drupal_set_message():                                                                    
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                                                    
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.                                                 
  91     PHPDoc tag @param has invalid value ($file_path                                                                      
         File physical path.): Unexpected token "$file_path", expected type at offset 61                                      
 ------ --------------------------------------------------------------------------------------------------------------------

                                                                                                                        
 [ERROR] Found 7 errors
jaykandari’s picture

jaykandari
Primary language Hindi
commented
Version: 8.x-1.1 » 2.x-dev
Assigned: Unassigned » jaykandari
Issue tags: +DIACWAug2020

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Assigned: jaykandari » Unassigned
Status: Needs review » Fixed

Added more changes to the patch and made module Drupal 9 compatible.
Merged & pushed to 2.x branch

Thank you all for your contributions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.