php drupal-check.phar modules/contrib/cleantalk/
 13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   src/EventSubscriber/BootSubscriber.php             
 ------ --------------------------------------------------- 
  155    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CleantalkCheckUsersForm.php               
 ------ --------------------------------------------------- 
  124    Call to deprecated function drupal_set_message().  
  155    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors
CommentFileSizeAuthor
#2 drupal_set_message-3072604-2.patch6.55 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_set_message-3072604-2.patch6.55 KB

Here is the patch, please review.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: drupal_set_message is deprecated » Many deprecated APIs in use
Status: Needs review » Reviewed & tested by the community

Looks good to me. There's a fair amount of whitenoise in the patch though. Any way to remove that and _only_ apply the changes for drupal_set_message?

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Many deprecated APIs in use » drupal_set_message is deprecated
serge-m’s picture

serge-m commented

Hello.

Does the problem persist in the newest version of the plugin?

The archive and our update guide are here:
https://cleantalk.org/help/update-drupal8

Thank you.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Yes, it does. We need to remove the old drupal_set_message calls and replace with the messenger service.

serge-m’s picture

serge-m commented

Thank you for the information.

We will investigate the issue in January 2020.

Please, wait.

davydovct’s picture

davydovct commented
Status: Reviewed & tested by the community » Fixed

Thanks, fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.