Problem/Motivation

The module needs a cleanup for adding or updating users. The module incorrectly tries to use the $infos variable where there is none.

Proposed resolution

Make sure the module does not trow unnecessary errors or notices when creating or updating users.

Remaining tasks

  • Remove function mailjet_user_cancel as this is not needed when using function mailjet_user_update.
  • Typehint the functions mailjet_user_insert, mailjet_user_update, mailjet_user_delete.
  • Update the function mailjet_sync_single_user to not trow errors.
  • Format the code to follow Drupal coding standards for the code that is changed.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

Clean up the user sync and fix errors on adding or updating users

CommentFileSizeAuthor
#5 interdiff_4_5.txt255 bytestim-diels
#5 3072024-5.patch6 KBtim-diels
#4 interdiff_2_4.txt5.98 KBtim-diels
#4 3072024-4.patch6.03 KBtim-diels
#2 3072024-2.patch12.12 KBtim-diels

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 3072024-2.patch12.12 KB

Please review patch.

mailjet plugins’s picture

mailjet plugins commented

I can not apply the provided patch:

$ git apply 3072024-2.patch
3072024-2.patch:249: trailing whitespace.

3072024-2.patch:251: trailing whitespace.

error: patch failed: mailjet.module:419
error: mailjet.module: patch does not apply

Can you please advice ?

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new 3072024-4.patch6.03 KB
new interdiff_2_4.txt5.98 KB

Sorry some more changes came trough than needed.
Adjusted patch so only changes that are needed comes trough.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new 3072024-5.patch6 KB
new interdiff_4_5.txt255 bytes

Removed debug code.

mailjet plugins’s picture

mailjet plugins commented
Assigned: Unassigned » mailjet plugins
mailjet plugins’s picture

mailjet plugins commented
Status: Needs review » Fixed

Hi, thanks for the provided patch! The issue has been fixed in version 8.x-2.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.