This makes automated tests impossible to run against the commerce submodule.

There was 1 error:

1) Drupal\Tests\....\Functional\CustomersCanvasTest::testBuilder
Drupal\Core\Config\Schema\SchemaIncompleteException: No schema for customers_canvas_commerce.settings
CommentFileSizeAuthor
#10 List of configuration data for customers_canvas_commerce settings.png108.79 KBskyredwang
#6 3072022-customers_canvance_commerce-schema_05.patch845 bytessafallia joseph
#4 3072022-04-tests-only.patch465 bytesjoshmiller
#4 3072022-04.patch1.12 KBjoshmiller
#3 3072022-03-tests-only.patch465 bytesjoshmiller
#3 3072022-03.patch682 bytesjoshmiller
#2 3072022-02.patch682 bytesjoshmiller

Comments

joshmiller created an issue. See original summary.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Active » Needs review
StatusFileSize
new 3072022-02.patch682 bytes
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
StatusFileSize
new 3072022-03.patch682 bytes
new 3072022-03-tests-only.patch465 bytes

With tests.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
StatusFileSize
new 3072022-04.patch1.12 KB
new 3072022-04-tests-only.patch465 bytes

Whoops forgot to include tests in the final round of changes.

Status: Needs review » Needs work

The last submitted patch, 4: 3072022-04-tests-only.patch, failed testing. View results

safallia joseph’s picture

safallia joseph commented
StatusFileSize
new 3072022-customers_canvance_commerce-schema_05.patch845 bytes

Re-rolled the patch to work against the latest branch

safallia joseph’s picture

safallia joseph commented
Status: Needs work » Needs review

The last submitted patch, 4: 3072022-04.patch, failed testing. View results

skyredwang’s picture

skyredwang
Location Shanghai
commented
skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs review » Needs work
StatusFileSize
new List of configuration data for customers_canvas_commerce settings.png108.79 KB

After applying the patch.

This is customers_canvas_commerce.settings.yml

order_item_type:
  standard: standard
  default: 0
  sample: 0
product_type:
  standard: standard
  default: 0
  sample: 0
redirect: commerce_cart.page
_core:
  default_config_hash: lxhuNUrkWGYWmuZwqGIbMtP3uBhxubl_bB0kjsOMgAc

and please see the errors in the screenshot.

I read the documentation https://www.drupal.org/docs/8/api/configuration-api/configuration-schema... a few times, and experimented many times, but still haven't figured it out.

skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs work » Fixed

With the help from @tbradbury and @josh, we were able to fix the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.