Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
31 Jul 2019 at 22:02 UTC
Updated:
2 Sep 2019 at 18:54 UTC
Jump to comment: Most recent
Comments
Comment #2
montesajudy commentedVery useful module for Drupal 8.
PAReview is reporting a few minor issues regarding drupal practice.
https://pareview.sh/pareview/https-git.drupal.org-project-user_extras.git
Comment #3
montesajudy commentedComment #4
avpadernoComment #5
avpadernoThank you for applying! Remember to change status, when the project is ready to be reviewed. The current status is telling users not to review it.
Comment #6
matiasmirandaThank you guys!, I sent the fixes:
https://pareview.sh/pareview/https-git.drupal.org-project-user_extras.git
Comment #7
vernitAfter review your module, my suggestion service should be under Service folder inside SRC.
Comment #8
vernitComment #9
matiasmirandaComment #10
avpadernoSince the role has not been assigned, the status cannot be changed to Fixed.
See my previous comment. The status you set for the application (Active) is used when the project is not ready to be reviewed. We cannot change it, as you are the only one who can tell us when we can proceed with reviewing the project code. Creating an application doesn't mean the code is ready to be reviewed.
Comment #11
matiasmirandaoh sorry. Thanks for the clarification
Comment #12
matiasmirandaComment #13
vuilThank you for the contribution!
Good job! Very good and excellent working Drupal service.
Congratulation!
There is not any security related issues into the code.
Comment #14
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #15
matiasmirandaThanks!!!!