php drupal-check.phar modules/contrib/message_notify/
 14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   message_notify.module                              
 ------ --------------------------------------------------- 
  43     Call to deprecated function entity_get_display().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error
CommentFileSizeAuthor
#8 replace_deprecated_e-3071526-8.patch713 bytesjhedstrom
#6 fix-test-error-entity-get-display-3071526-5.patch1.86 KBpatelmayank7552
#4 entity-get-display-3071526-4.patch1.86 KBpatelmayank7552
#2 entity_get_display-3071526-2.patch849 bytessergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new entity_get_display-3071526-2.patch849 bytes

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: entity_get_display-3071526-2.patch, failed testing. View results

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
StatusFileSize
new entity-get-display-3071526-4.patch1.86 KB

Hi,

I have uploaded the new patch.

Please review it.

Status: Needs review » Needs work

The last submitted patch, 4: entity-get-display-3071526-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
StatusFileSize
new fix-test-error-entity-get-display-3071526-5.patch1.86 KB

Fix test error

Status: Needs review » Needs work

The last submitted patch, 6: fix-test-error-entity-get-display-3071526-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new replace_deprecated_e-3071526-8.patch713 bytes

This uses the updated replacement for the deprecated function.

  • jhedstrom committed 4c1db20 on 8.x-1.x 
    Issue #3071526 by patelmayank7552, Sergiu Stici, jhedstrom: Replace...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.