The upgrade status module flags taxonomy_entity_index's use of db_delete() in the main module file. These should be replaced with calls to the delete method on the database object.

CommentFileSizeAuthor
#5 deprecated-3070719-5.patch13.26 KBbrian.seek
#2 deprecated-3070719-2.patch12.8 KBsergiu stici

Comments

cameronprince created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new deprecated-3070719-2.patch12.8 KB 
php drupal-check.phar modules/contrib/taxonomy_entity_index/
 10/10 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------- 
  Line   includes/taxonomy_entity_index.tokens.inc                                          
 ------ ----------------------------------------------------------------------------------- 
  20     Call to deprecated method entityManager() of class Drupal.                         
  41     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.  
  90     Call to deprecated function db_query().                                            
  95     Call to deprecated method entityManager() of class Drupal.                         
 ------ ----------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/TaxonomyEntityIndexAdminForm.php          
 ------ --------------------------------------------------- 
  97     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------- 
  Line   src/Plugin/views/argument/TaxonomyEntityIndexTidDepth.php  
 ------ ----------------------------------------------------------- 
  53     Call to deprecated function db_select().                   
  55     Call to deprecated function db_or().                       
 ------ ----------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Plugin/views/field/TaxonomyEntityIndexTid.php  
 ------ --------------------------------------------------- 
  76     Call to deprecated function db_select().           
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------------- 
  Line   src/Plugin/views/filter/TaxonomyEntityIndexTidDepth.php  
 ------ --------------------------------------------------------- 
  75     Call to deprecated function db_select().                 
  80     Call to deprecated function db_or().                     
 ------ --------------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   taxonomy_entity_index.module                                
 ------ ------------------------------------------------------------ 
  16     Call to deprecated function db_delete().                    
  27     Call to deprecated function db_delete().                    
  37     Call to deprecated function db_delete().                    
  46     Call to deprecated function db_delete().                    
  86     Call to deprecated function db_delete().                    
  112    Call to deprecated function db_insert().                    
  152    Call to deprecated method entityManager() of class Drupal.  
  196    Call to deprecated function db_delete().                    
  262    Call to deprecated function drupal_set_message().           
  266    Call to deprecated function drupal_set_message().           
 ------ ------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 20 errors

I provided a patch, please review.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
cameron prince’s picture

cameron prince commented
Status: Needs review » Reviewed & tested by the community

Thanks @sergiu-stici. I've reviewed and tested the patch. It looks good and I'll get this committed shortly.

brian.seek’s picture

brian.seek commented
StatusFileSize
new deprecated-3070719-5.patch13.26 KB

Here is an updated patch from Sergiu's initial patch. Added required arguments in construct for TaxonomyIndexTidDepth parent.

cameron prince’s picture

cameron prince commented
Status: Reviewed & tested by the community » Needs review

The updated patch @brianseek provided has been committed and taxonomy_entity_index 8.x-1.x-dev release has been created.

I'm going to set this back to needs review so that we can test it there before creating a follow-up alpha release and marking this as fixed.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

This looks good and works for me, but as some things were missing, there are follow-up issues which should be included in the release as well:

While not directly related, you may as well include #3075503: Views filter and arg doesn't take revisions into account in the next alpha as well, as it's the only other D8 issue still open.

cameron prince’s picture

cameron prince commented
Status: Reviewed & tested by the community » Fixed

Thanks @colan! I agree and should have a new release ready shortly.

Marking this as fixed now as it's committed and has been tested pretty extensively over the past few months.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.