While evaluating this module, while it missing the readme.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

CommentFileSizeAuthor
#7 Screenshot 2019-07-29 at 12.20.51 PM.png639.63 KBkunalkursija
#5 phone_registration-3070586-5.patch958 bytesjaspreetsingh31
#2 phone_registration-3070586-1.patch959 bytesvernit

Comments

Vernit created an issue. See original summary.

vernit’s picture

vernit
he/him
Primary language English
Location India
commented
StatusFileSize
new phone_registration-3070586-1.patch959 bytes
alonaoneill’s picture

alonaoneill commented
Assigned: vernit » Unassigned
Status: Needs review » Needs work 
+++ b/README.md
@@ -0,0 +1,38 @@
+* This module requires no modules outside of Drupal core..

Delete extra "."

djsagar’s picture

djsagar commented
Status: Needs work » Reviewed & tested by the community
jaspreetsingh31’s picture

jaspreetsingh31 commented
StatusFileSize
new phone_registration-3070586-5.patch958 bytes

As per suggested by @alonaoneill in comment #3, I have removed the additional dot from the requirement section.

Changing the issue status to "Need review"

jaspreetsingh31’s picture

jaspreetsingh31 commented
Status: Reviewed & tested by the community » Needs review
kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2019-07-29 at 12.20.51 PM.png639.63 KB

The patch submitted by @jaspreetsingh31 in #5 applied cleanly with suggestions by @alonaoneill.
Attaching screenshot.
Changing status to RTBC.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.