Problem/Motivation

Drupal\views_ui\ViewEditForm::form has dependency to jQuery UI tabs, but this dependency is no longer needed. Code depending on jQuery UI tabs was removed on this issue: #1884180: Cleanup base.js for real. There's some discussion related to this here as well: #697224: Replace $.viewsUI.tabs with $.ui.tabs, which mentions that the client side tabs were transformed into separate pages.

Proposed resolution

Remove dependency to jQuery UI tabs from Drupal\views_ui\ViewEditForm::form.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3070369-2.patch606 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3070369-2.patch606 bytes
zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
commented

Before this patch, a views edit page loads

  • /core/assets/vendor/jquery.ui/themes/base/tabs.css?pv5vla
  • /core/assets/vendor/jquery.ui/ui/widgets/tabs-min.js?v=1.12.1

After applying the patch these 2 files are no longer loaded, and views continues to work without any errors.
Nice job researching this @lauriii, this is a good fix.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

I'm getting the same results as @zrpnr, and did a bit of overly-cautious regexing to supplement the already well researched conclusion that this dependency is unnecessary. RTBC.

  • catch committed 8c898fc on 8.8.x 
    Issue #3070369 by lauriii, zrpnr, bnjmnm: Remove Drupal\views_ui\...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 8c898fc and pushed to 8.8.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Woah, nice find!

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » xjm
Status: Fixed » Needs work
Issue tags: +Needs change record

Just going to add a small CR noting this.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Needs work » Fixed
Issue tags: -Needs change record

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.