Closed (fixed)
Project:
PWA - Progressive Web App
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
24 Jul 2019 at 15:54 UTC
Updated:
5 Sep 2019 at 16:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexborsody commentedThat start_url isn't right it should start with a /
Comment #3
zenimagine commented@AlexBorsody Thank you, I made the change but I still have the mistake
Comment #4
christophweber commentedPlease be sure to delete your existing service worker.
Comment #5
zenimagine commented@ChristophWeber I just change the number of "Cache version" but I still have the error
Comment #6
zenimagine commentedHere is my site if you want to test (it is not in English)
https://www.s1biose.com/fr
Comment #7
zenimagine commentedComment #8
ruplWhen I look at the URL, it appears that slashes inside manifest.json are being escaped when they don't need to be:
Comment #9
zenimagine commented@rupl I do not understand, what should I do to correct? I also have a lot of problem with the logo because the module does not create the right path https://www.drupal.org/project/pwa/issues/3070050
Comment #10
ruplI wasn't recommending an immediate solution, but wanted to point out that the manifest.json seems to be outputting malformed values for
start_urland the URIs for icons.When I read the docs for json_encode I see in the
$optionsthe possibility of settingJSON_UNESCAPED_SLASHES. I believe this would fix the problem.Can you try this patch and see what happens?
Comment #11
ruplSorry, I read the docs wrong and the
array()was unnecessary. New patch in this comment.Comment #12
zenimagine commented@rupl Thank you, I applied the patch but no change
Comment #13
ruplBuddy you gotta read how issue statuses work please.
Comment #14
zenimagine commented@rupl It is very surprising that I am the only one to have these problems. Why is the path to the logo not a Uri ? What does the domain name do in the way ? I feel that this module has never been tested on a domain name.
Comment #15
zenimagine commentedBefore installing this module, I had my own file at the root with this data and no problem. But I miss him the service worker :
Comment #16
rupl@zenimagine you're right, this module has been tested on very few production websites. We just released the first beta a few days ago, which seems to be what brought you here. It's not a stable module yet, so it puzzles me you have such high expectations.
We appreciate all testing and feedback, but (as with the rest of Drupal) it comes with the standard disclaimer that you're using free, open source software with absolutely no warranty. If you want every problem fixed immediately, you can speed the process by providing patches, or you can hire either myself or another maintainer for contract work.
Comment #17
zenimagine commentedThis module should be in alpha
Comment #18
christophweber commentedThe escapes for slashes bug me. That's not coming from the pwa module, but from other code that outputs JSON. You have schema_metatag module in play per https://www.drupal.org/project/pwa/issues/3070050 which, if I recall correctly, escapes slashes in its output JSON-LD. Reviewing that now, but if you could please disable schema_metatag and report back whether the problem with your manifest persists.
My hunch is that various modules are overly global or generic while hooking into the JSON filtering and output process, including perhaps us here.
Comment #19
christophweber commentedThat said, rupl is right, you need to realize that this module is in heavy development at the moment, and also that this project is run by volunteers who may or may not get paid by a company to maintain community projects. If our company were to bill for our time put into here the invoice would be fairly substantial already.
In the meantime thank you for the time you have put in testing, and reporting and documenting issues.
Comment #20
ruploh what? if this isn't being tested on a clean install it's not even a bug report yet. this is support, plain and simple.
@zenimagine please install the D8 PWA module on a clean install of D8 and see if the problem persists. Until then this is a support request and we can safely de-prioritize. Please do not reclassify the Priority or Status until you have reproduced on a fresh D8 install that includes no other modules.
Comment #21
alexborsody commentedTry this patch on the latest dev.
Comment #22
alexborsody commentedComment #23
alexborsody commentedComment #24
zenimagine commented@AlexBorsody Sorry, I applied the patch on the latest version dev, but still the same problem.
Comment #25
ruplSo one question: you have configured the SW to cache your start URL, correct? Overall I'm wishing you would provide more information we could use to provide support. Simply telling us that it didn't fix your support request gives people very few options in terms of next steps.
Comment #26
zenimagine commented@rupl I kept the default configuration.
Comment #27
alexborsody commentedVisiting your site now I see start_url is loading and no errors.
Comment #28
zenimagine commented@AlexBorsody Hello, yes it's true since the logo patch is applied. If you make an "audit" there is the error
Comment #29
alexborsody commentedComment #30
alexborsody commentedOk so I am implementing this on a site now with a similar redirect to you and got the same error, the reason this is showing is that you are using / as the start URL and it should be /fr (in your case), or wherever your page is redirecting to. When Chrome is doing the Lighthouse testing this is registering as a redirect.
Comment #31
alexborsody commentedComment #32
alexborsody commented