Just wanted to let other developers know that this module is affected by this core issue: #3069578: Layout builder doesn't show new "extra fields"

So you may have problems in combination with layout_builder. This issue should be closed fixed when the core issue is fixed & committed.

As workaround you can remove the extra fields from "hidden" in the configuration.

CommentFileSizeAuthor
#8 layout-builder-extra-fields-3069732-8-8.8.x.patch2.44 KBgruda
#3 interdiff_failed_passed.txt667 bytesYurkinPark
#3 layout-builder-3069732-3-TESTS-ONLY--FAILED.patch2.05 KBYurkinPark
#3 layout-builder-3069732-3-TESTS-ONLY--PASSED.patch1.88 KBYurkinPark

Comments

Anybody created an issue. See original summary.

sutharsan’s picture

sutharsan commented

Thanks for documenting this issue.

YurkinPark’s picture

YurkinPark commented
Status: Postponed » Needs review
StatusFileSize
new layout-builder-3069732-3-TESTS-ONLY--PASSED.patch1.88 KB
new layout-builder-3069732-3-TESTS-ONLY--FAILED.patch2.05 KB
new interdiff_failed_passed.txt667 bytes

Test, attached in "--PASSED" file describe regular issue we face during development: when we are creating extra fields for already created and configured entity types and its displays.

Status: Needs review » Needs work

The last submitted patch, 3: layout-builder-3069732-3-TESTS-ONLY--FAILED.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

Nice test and fix!

Order of patches matters, test-only should go first)

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/tests/src/Functional/ExtraFieldLayoutBuilderDisplayTest.php
@@ -0,0 +1,63 @@
+    $this->drupalGet('/admin/structure/types/manage/article/display/default');
...
+    $this->drupalGet('/layout_builder/add/block/defaults/node.article.default/0/content/extra_field_block%3Anode%3Aarticle%3Aextra_field_all_node_types_test');
...
+    $this->drupalGet('/node/' . $this->nodeEntity->id());

Probably URLs could remove leading "/" on commit

YurkinPark’s picture

YurkinPark commented
Status: Reviewed & tested by the community » Needs work

There are tests only, no fix inside yet

gruda’s picture

gruda commented
StatusFileSize
new layout-builder-extra-fields-3069732-8-8.8.x.patch2.44 KB

This is the patch from the core issue, re-rolled for 8.8.x core.

sutharsan’s picture

sutharsan commented
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Happy news! The core issue was fixed! #3069578: Layout builder doesn't show new "extra fields"
How should we proceed here? Sadly it was only commited to 9.1, I'll ask if a backport is possible. Any other options here?

andypost’s picture

andypost
he/him
Primary language Russian
commented

btw in 10 days 9.1.0 will be released so better to decide how it will affect next release in terms of semver

sutharsan’s picture

sutharsan commented

@andypost, I don’t understand, pls explain. Any proposal?

andypost’s picture

andypost
he/him
Primary language Russian
commented

There's nothing to fix in module with 9.1 so next minor release may note (known regressions) at release to upgrade core and link to issue where patch is

sutharsan’s picture

sutharsan commented
Status: Needs work » Closed (outdated)

As mentioned in the initial post, this issue no longer applies to the current Drupal (9) version. With the upcoming Drupal 8 end of life I will close this issue, no new development only for Drupal 8.