Hi all,
I've seen a little bug after having created my own user register form.
I'm using form_mode_manager version: '8.x-2.0-rc3'
In a multilingual site the string "@op @name as @form_mode_label" gets always the original label and not the translated one.
I fixed this adding this code in "src/AbstractEntityFormModesFactory.php" at line 272

original: '@form_mode_label' => $form_mode_label,

modifiied: '@form_mode_label' => t($form_mode_label)

I hope this could help.

CommentFileSizeAuthor
#3 title-not-translated_3069630_3.patch938 bytesanas_maw

Comments

foonambolo created an issue. See original summary.

anas_maw’s picture

anas_maw commented
Title: page title form mode label » Page title is not translated
Status: Needs review » Needs work

The translation should come from the form mode config translation, there is something missing here.

anas_maw’s picture

anas_maw commented
Status: Needs work » Needs review
StatusFileSize
new title-not-translated_3069630_3.patch938 bytes

This patch will solve the issue

anas_maw’s picture

anas_maw commented
Version: 8.x-2.0-rc3 » 8.x-2.x-dev
dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work
Issue tags: -label form mode user +Needs manual testing

I just marked #3100112: Replace bundle_type_id with Label for Page Title / Routing duplicate with this. That's a whole other approach. I'd rather use the simpler fix proposed here, if it works.

I'm tempted to tag this as "Needs tests", since I'd only like to commit bug fixes that include test coverage.

However, in this case, we'd basically just be testing core's translation system, which is already tested. ;) So I think we should probably just change this and move on. But I'd like to see someone else confirm this works via manual testing. Feel free to supply a new patch with an automated test if you'd rather. ;)

Thanks!
-Derek