[D8] Schema App

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

The master branch is not correct. For Drupal 8, a branch like 8.x-1.x should be used.

It is also not clear if the account used to commit the code is a shared account, or an account used by a single person. The absence of first and last name, and the email associated with the account lead me to think this is a shared account.

Ok thank you for the quick response, sorry for my delay I'm still very new to Drupal. I have updated my master branch and re-ran that PAR review and I believe everything is passing. I think it was using an old branch before I had made those fixes, I have gone through and set a version 8 branch and it is now the default.

The account is shared yes, in the repo one developer has been working on it but Schema App is an organization.

Basing on the Drupal.org Terms of Service, a shared account cannot be used for the following.

If you are sharing your user account with multiple people (e.g. as your “official” organization account), you are not allowed to do the following using this account:

• commit code to Git repositories on the Website
• create any nodes except for organization, case study or project nodes
• comment on nodes

Each developer writing the code needs to use an account used only from that developer. The only way to continue this application is to give to the developer his/her account, and use that for continuing the application.

Thank you for the contribution!

Please increase the project's page content, see more about Module documentation guidelines and Project page template. I created project issue about.

While a better description of the module would help users who need the module, or are thinking to use the module, we review the files committed in the repository.

Thank you for the contribution!

I have not found any security related issues in the code.

Thanks for you contribution!

1. schemaapp_page_attachments_alter(): do not concatenate variables into logger strings, use placeholders instead.
2. config schema is missing, see https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...
3. CacheTest extends UnitTestCase, so it is not a Functional test and in the wrong folder. Should be in "Unit"

Otherwise looks good to me, did not see security issues.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

joelcummings has not set a Git username, nor has he consented to the Git agreement. Without those steps, this application cannot be approved.