------ --------------------------------------------------- 
  Line   modules​/​contrib​/​config_perms​/​src​/​Form​/​ConfigPermListForm.php                               
 ------ --------------------------------------------------- 
  252     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 


 ------ --------------------------------------------------- 
  Line   modules​/​contrib​/​config_perms​/​src​/​Form​/​CustomPermsEntityDeleteForm.php                                
 ------ --------------------------------------------------- 
 41     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 

                                                                                                                  
 [ERROR] Found 2 error
CommentFileSizeAuthor
#5 3068737-2-5-interdiff.txt1.05 KBgnuget
#5 3068737-5.patch1.02 KBgnuget
#2 373990-2.patch1.03 KBmohammad-fayoumi

Comments

Mohammad Fayoumi created an issue. See original summary.

mohammad-fayoumi’s picture

mohammad-fayoumi
Primary language English
Location Amman
commented
StatusFileSize
new 373990-2.patch1.03 KB
rudranil29’s picture

rudranil29 commented
Assigned: Unassigned » rudranil29
Status: Active » Needs review
rudranil29’s picture

rudranil29 commented
Status: Needs review » Reviewed & tested by the community

Looks good

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3068737-5.patch1.02 KB
new 3068737-2-5-interdiff.txt1.05 KB

This looks great but FormBase already use the MessengerTrait so any form (which extends this class) can use directly the messenger() method, no need to use the container wrapper.

New patch attached.

rudranil29’s picture

rudranil29 commented
Status: Needs review » Reviewed & tested by the community

@gnuget yes you are right, while reviewing I forgot to check extend class

  • gnuget committed b35c6e1 on 8.x-2.x 
    Issue #3068737 by gnuget, Mohammad Fayoumi, joy29: Drupal 9 Deprecated...
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.