Closed (duplicate)
Project:
Read Time
Version:
8.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jul 2019 at 12:18 UTC
Updated:
12 Nov 2021 at 20:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sergiu stici commentedHere is the patch, please review.
Comment #3
patelmayank7552 commentedComment #4
patelmayank7552 commentedHi @s-jack,
I have applied the patch in the module and it's working fine.
Thanks.
Comment #5
mmjvb commented@patelmayank7552 Please refrain from assigning to yourself when reviewing. Only assign to yourself when planning to provide a solution.
Comment #6
s-jack commentedHi patelmayank7552.
I am sorry for my late response.
Thank you for creating a patch file.
I did the following and got the message.
patch --dry-run -p1 < string_error-3068116-2.patch
patch: **** Only garbage was found in the patch input.
How can I apply the patch?
Comment #7
mmjvb commentedMake sure you are in the folder of read_time. Then issue: patch < string_error-3068116-2.patch
This assumes you moved the patch into the read_time folder.
Comment #8
s-jack commentedThank you, mmjvb and everyone.
I successed to apply patching.
Patch seems to work well for me.
Comment #9
a3hill commentedPatched successful for me.
Comment #10
valthebaldCould removing of double t() be better? https://www.drupal.org/project/read_time/issues/3051696#comment-13173623
Comment #11
zanvidmar commentedPatch successfully applied. Thank you.
Comment #12
jplana commentedPatch solved the error for me. Thank you.
Comment #13
dqdExchanged closed/duplicate state of both related issues respecting the D.O. recommendation to close the newer regarding the older one, but I am still not convinced yet that these 2 issues are duplicates. Please review this again. But apart from that the older one has better title, description and more different patch approaches than this one here anyways.
BTW: https://www.drupal.org/files/issues/2019-07-08/3051696-5.patch is exactly the same patch than the one provided here.
Comment #14
joco_sp commentedAs per the comment above the solution from the issue #3051696 was applied, because it was created first and the patches there solve 2 issues.
Thank you for the help. I credited all of you on the other issue. If you'll still have this error, please re-open it.
The fix will be available in the new version.