Problem/Motivation

The module changes the behaviour of the language switch compared to Drupal Core, but does not provide any automated test coverage of its own. This means the module may break when Drupal Core is updated.

Proposed resolution

Add automated test coverage.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 3067231-3.patch1.52 KBidebr
#3 interdiff-2-3.txt741 bytesidebr
#2 3067231-2.patch1.46 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3067231-2.patch1.46 KB

Attached patch adds the initial \Drupal\Tests\language_switcher_enhanced\FunctionalJavascript\LanguageSwitcherEnhancedUiTest. It probably needs more assertions about finding links, and testing the fallback options.

idebr’s picture

idebr commented
StatusFileSize
new interdiff-2-3.txt741 bytes
new 3067231-3.patch1.52 KB

Added test coverage for #3067232: Configuration schema for block settings is not applied

Status: Needs review » Needs work

The last submitted patch, 3: 3067231-3.patch, failed testing. View results

zerdiox’s picture

zerdiox commented

Once the schema is in order we can hopefully successfully add this test. I'll then see if I can expand them properly. This will take some time I'm afraid because I'm not yet well versed in writing tests.

Either way, thank you for the start!

  • Zerdiox committed fc7ac05 on 8.x-1.x 
    Issue #3067231 by idebr: Add automated test coverage
zerdiox’s picture

zerdiox commented

We have a successful patch!! I'll be adding it to the project.

idebr’s picture

idebr commented
Status: Needs work » Fixed

The automated tests are now running on commit: https://www.drupal.org/node/3059589/qa

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.