This module creates an Action plugin that can assign/update a user's group role for multiple groups in once.

When you are managing a site with many groups, it could be painful to update a user's role for multiple groups, e.g. giving a user admin role in tens of groups, which requires changing configurations repeatedly for each group . This module provides the capability to update a user's roles for as many groups as you want in one time.

Project link

https://www.drupal.org/project/group_bulk_operations

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/group_bulk_operations.git

Pareview

https://pareview.sh/pareview/https-git.drupal.org-project-group_bulk_ope...

Comments

wangshy created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Needs work

Thank you for the contribution!

Please fix at first the issues mentioned in the Pareview.

Then, please update all deprecated class and method usages as the following:
EntityManagerInterface, PrivateTempStoreFactory, drupal_set_message(), etc.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Drupal 8 modules can still use deprecated classes/functions, as those will be removed with Drupal 9.

What is wrong is using t() in a class that extends ConfirmFormBase, where the t() method is available.
The README file doesn't follow the Drupal coding standards. The lines should not be longer than 80 characters.

wangshy’s picture

wangshy commented

@ilchovuchkov @kiamlaluno, thanks for your review. I've fixed the problems you pointed out on 8.x-1.x-dev latest commit.

wangshy’s picture

wangshy commented
Status: Needs work » Needs review
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Needs work

Thank you for the contribution!

1. Please, always keep attention on project's issues because you are the maintainer.

2. Drupal\system\Plugin\views\field\BulkForm has been deprecated in favour of Drupal\views\Plugin\views\field\BulkForm.

The bulk_form plugin was located in the System module and has been moved to the Views module, the old version of the plugin has been deprecated. Existing plugins that extend Drupal\system\Plugin\views\field\BulkForm should now extend Drupal\views\Plugin\views\field\BulkForm instead.

Also the data_type schema for views_field_bulk_form was moved from core.data_types.schema.yml to the Views module. This should have no influence on plugins using this schema. See more here and here.

And please, be patience through the whole security review process.

wangshy’s picture

wangshy commented
Status: Needs work » Needs review

@ilchovuchkov, thanks, all issues have been fixed on 1.x-dev.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Thanks for you contribution!

All looking good to me here, I don't see security issues.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.