Fatal error when trying to invoke non-existing action callbacks [#306611]

Currently, actions (defined in database) are invoked as follows on lin 99 of actions.inc

  $result[$action_ids] = $function($object, $context, $a1, $a2);

This creates problems where a trigger/action may be defined in the database, but a module supporting the action $function is disabled, resulting in a showstopping fatal error, which you'd need to manually edit the database to fix. Bad news!

This can be prevented by using call_user_func() as we do in a number of other places:

      $result[$action_ids] = call_user_funct($function, $object, $context, $a1, $a2);

That will simply return FALSE if for some reason the action function is undefined. I can roll a patch against 6.x-dev if that helps.

Comment	File	Size	Author
#13	306611-function-exists_d6.patch	2.59 KB	andypost
#12	drupal.actions-function-exists_0.patch	1.72 KB	dawehner
#10	drupal.actions-function-exists.patch	1.49 KB	dawehner
#5	drupal.actions-function-exists.patch	1.71 KB	sun
#2	drupal-7x-dev-306611-1.patch	710 bytes	jbomb

Comments

Comment #1

damien tournoud commented 10 September 2008 at 22:44

Version:	6.4	» 7.x-dev
Category:	feature	» bug
Priority:	Normal	» Critical

Bumped to D7. This will need to be wrapped into a function_exists for D6 and a drupal_function_exists for D7.

Bumped to critical because that's something that should have been converted when the registry patch landed in D7.

Comment #2

jbomb commented 27 March 2009 at 00:15

Status:

Active

» Needs review

Status	File	Size
new	drupal-7x-dev-306611-1.patch	710 bytes

attached is the requested patch from #1.

Comment #3

webchick

she/they

English

Vancouver 🇨🇦

commented 27 March 2009 at 00:20

We should probably expand our tests to cover this case, no?

Comment #4

pp commented 26 April 2009 at 12:55

Status:

Needs review

» Needs work

How do I reproduce the bug?

I think the patch is not good. I saw the actions.inc and found two place where problem presents the patch just resolve one.
85. and 100. line contains:
$result[$action_id] = $function($object, $context, $a1, $a2);

Comment #5

sun

German

Karlsruhe

commented 19 September 2009 at 21:12

Title:	Update actions.inc to use call_user_func()	» Fatal error when trying to invoke non-existing action callbacks
Status:	Needs work	» Needs review
Issue tags:		+actions, +API clean-up

Status	File	Size
new	drupal.actions-function-exists.patch	1.71 KB

Tagging.

Regarding tests, please see #582316: Add tests for actions. It makes no sense to hold off this patch, because we have no tests and especially no pattern for tests for actions yet.

Comment #6

dawehner

German

commented 19 September 2009 at 23:13

Status:

Needs review

» Reviewed & tested by the community

+++ includes/actions.inc	19 Sep 2009 21:10:47 -0000
@@ -77,8 +77,13 @@ function actions_do($action_ids, $object
+          $actions_result[$action_id] = FALSE;

The actions return NULL. So FALSE is a sign of an error. Thanks for explaining me this sun.
Thats also good for testing this functionality later.