In combination with the field validation module, the validation handler added to the next button breaks other validations. it also seems to me that the handler isn't a validation handler but rather a submit handler. I will add a patch to change it to a submit handler.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | remove-implements-alter-from-field-group.patch | 713 bytes | el1_1el |
| #18 | simple_multistep_1x_restore.patch | 13.54 KB | el1_1el |
| #8 | 3066080-update-validation-8.patch | 2.17 KB | el1_1el |
| #2 | simple_multistep-broken_validation-3066080-2.patch | 528 bytes | cgoffin |
| #3 | simple_multistep-broken_validation-3066080-3.patch | 855 bytes | cgoffin |
Issue fork simple_multistep-3066080
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
cgoffin commentedAttached the patch to fix broken validations.
Comment #3
cgoffin commentedWrong handler adjusted, fixed patch attached.
Comment #4
cgoffin commentedSubmit handler isn't triggered, applied fix.
Comment #5
cgoffin commentedThere is a problem with the validation on the next steps. To make sure all values are on the entity object I added the validation function to the form, to be executed on each form submit.
Comment #6
rajdeep0826 commentedComment #7
el1_1el commentedThe patch in #6 mostly works except changing from
validatetosubmitcreates issues with multi value image and file fields in later steps causing multiple upload widgets in the field depending on how may steps into the form they are.It also creates a validation failure if a required field is in a later step.This patch should address both of those issues for 1.0.This patch should address the issue for 1.0.if you need the patch for dev it looks like you'll just need to change
'#weight' => 0.1,to'#weight' => -1,in src/FormButton.php but I have not verified that.Comment #8
el1_1el commentedIt also creates a validation failure if a required field is in a later step.My mistake. The file and image fields are an issue still.Comment #9
el1_1el commentedComment #10
nevergone#8 tested and works well.
Comment #13
andrei.vesterliThe patch
3066080-update-validation-8.patchwas applied to the repo. Thx for your support guys!Comment #15
andrei.vesterliComment #16
andrei.vesterliComment #17
mohamed.osama commentedStill have the issue after applying the patch
Comment #18
el1_1el commentedIf anyone else finds they have custom code relying on this commit as well as the api from the 1.0.x version, or is just having other issues with the 1-2 update, and needs to update to drupal 10, I've attached a patch that restores the 1x version on 2.0 for drupal 10.
Also note that you may need to apply the patch for field_group that removes its implements_alter function from the 3.4 version