Description

External Link Pop-up module provides confirmation pop-up on external link click, that follows out of the site. The module supports multiple pop-ups and have options to allow some links don't show pop-ups.

The module uses the core/drupal.dialog library, which is build on the jquery.ui.dialog library.

Just install the module for basic usage. It attached JS code and settings to all non-admin pages of the site and shows dialog on all links that follows outside. Note: target attribute of the link used to open location on the same or new tab.

More theming and configuration information provided on the module page.

Project link

https://www.drupal.org/project/external_link_popup

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/external_link_popup.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-external_link_...

Comments

dewalt created an issue. See original summary.

ysamoylenko’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your contribution!

Review:
* Project's code looks good for me.
* Have not found any issues during module installation and configuration.
* Popups are shown as expected.
* Domains white list works as expected.

Pareview`s report doesn't contain any issues but contains one recommendation:

No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

I think that the module is ready to be covered by:
Drupal.org security advisory coverage

avpaderno’s picture

Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

pifagor’s picture

Perfectly

dewalt’s picture

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.