Rewrite plugin does not work after Explode

Just checked that patch works correctly with the latest version of the module

git apply -v rewrite_after_explode-3065458-2.patch
Checking patch src/Plugin/Tamper/Rewrite.php...
Applied patch src/Plugin/Tamper/Rewrite.php cleanly.

Thanks.

We should write a test to make sure the rewrite plugin works after the explode plugin as expected.

Maybe something like:

0) Make sure [enemy] token is set to string "ghost"
1) Source is: "Pacman, yellow ghost, red, ghost, blue ghost"
2) Explode into ["Pacman", "yellow [enemy]", "red [enemy]", "blue [enemy]"]
3) Use rewrite to update values to:
4) ["Pacman", "yellow ghost", "red ghost", "blue ghost"]

Sorry should be:

0) Make sure [enemy] token is set to string "ghost"
1) Source is: "Pacman, yellow [enemy], red [enemy], blue [enemy]"
2) Explode into ["Pacman", "yellow [enemy]", "red [enemy]", "blue [enemy]"]
3) Use rewrite to update values to:
4) ["Pacman", "yellow ghost", "red ghost", "blue ghost"]

@jamesdixon do you have any advice on how to link plugins in tests ?
I tried to write this test but it's not working :

  /**
   * Tests if rewrite is working after explode.
   */
  public function testRewriteAfterExplode() {
    $source = "Pacman, yellow [enemy], red [enemy], blue [enemy]";
    $expected = ["Pacman", "yellow ghost", "red ghost", "blue ghost"];

    $explode_config = [
      Explode::SETTING_SEPARATOR => ', ',
    ];
    $explode_plugin = new Explode($explode_config, 'explode', [], $this->getMockSourceDefinition());
    $explode_result = $explode_plugin->tamper($source);

    $config = [
      Rewrite::SETTING_TEXT => '[source]',
    ];
    $plugin = new Rewrite($config, 'rewrite', [], $this->getMockSourceDefinition());
    $this->assertEquals($expected, $plugin->tamper($explode_result));

  }

There was 1 failure:

1) Drupal\Tests\tamper\Unit\Plugin\Tamper\RewriteTest::testRewriteAfterExplode
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'Pacman'
-    1 => 'yellow ghost'
-    2 => 'red ghost'
-    3 => 'blue ghost'
+    1 => 'yellow [enemy]'
+    2 => 'red [enemy]'
+    3 => 'blue [enemy]'
 )

A fix for this issue is now available in a combination of two other issues:

• #3323381: Rewrite plugin: when using own source key in chain the initial value is used
  This ensures that the data of previously applied Tamper plugins (thus before the Rewrite plugin) is written back to the item. The Rewrite plugin then finds the most up to date data on the item.
• #3224959: Rewrite plugin: iterate through values to rewrite
  Among other things, this adds support for arrays for the Rewrite plugin. If your initial source value is for example Foo,Bar,Qux and you explode that using a comma as separator and then use the Rewrite plugin to add a "x" to it, you'll get ["Foox","Barx","Quxx"] instead of ["Foox","Foox","Foox"].

Closing this as a duplicate now.