QueryAccessHandlerBase throws an exception like

The "$entity_type_id" entity type did not define a "uid" key.

for any entity type using the EntityOwnerTrait introduced in Drupal 8.7

CommentFileSizeAuthor
#4 3065178-4.patch3.56 KBtstoeckler
#4 3065178-2-4-interdiff.txt1.19 KBtstoeckler
#2 3065178-2.patch3.32 KBtstoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3065178-2.patch3.32 KB

Here we go. Only tested this on 8.7.x (will provide a patch for #3065163: Require Drupal 8.7 and use EntityOwnerTrait in a minute), so not sure what happens on 8.6.x.

Status: Needs review » Needs work

The last submitted patch, 2: 3065178-2.patch, failed testing. View results

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 3065178-2-4-interdiff.txt1.19 KB
new 3065178-4.patch3.56 KB

Tested this with #3065163: Require Drupal 8.7 and use EntityOwnerTrait so I didn't catch the broken "uid" key code path. Let's see how this does.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

OK, sweet. So I didn't provide explicit test coverage because with #3065163: Require Drupal 8.7 and use EntityOwnerTrait we will get automatic test coverage of the 'owner' key code path. The 'uid' key is really just a leftover from Node module so I'm not sure that deserves explicit test coverage.

  • bojanz committed 70e0aec on 8.x-1.x authored by tstoeckler 
    Issue #3065178 by tstoeckler: Support the "owner" key in...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.