This module allows showing results from one views display within another with configurable spacing. This allows you to build views where, for example, every third row is a blog post while all others are articles, or where every n-th row shows sponsored content.

Project link

https://www.drupal.org/project/views_inject

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/views_inject.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-views_inject.git

Comments

Mirroar created an issue. See original summary.

Mirroar’s picture

Mirroar commented

I forgot to mention that I ran the project through PAReview and fixed the few issues that came up.

Thanks to anybody that takes the time to review.

bekirdag’s picture

bekirdag commented
Status: Needs review » Needs work

Hello,

You may like to create automated tests and have an alpha branch instead of a stable release since a views injection module is a big deal and there are open issues for the module currently.

One more thing, you have to add a dependency on your info yml file for "views" since your module depends on it.

Other than those, it looks good to me,

Thanks for sharing!

Mirroar’s picture

Mirroar commented
Related issues: +#3063769: Overflow of injected items leads to strange result counts, +#3063868: Add tests

Thank you for the feedback.
You must have looked at the 1.0 release, because the dev version has the dependency to views added.
I completely agree that there should be tests added, I'll try to add them in the near future.

I'll get back to you once the following issues are fixed, which should be good enough for a new beta or RC release:
#3063769: Overflow of injected items leads to strange result counts
#3063868: Add tests

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Needs review
Related issues: -#3063769: Overflow of injected items leads to strange result counts, -#3063868: Add tests

Thank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Needs work

Hello,
Thank you for the contribution!

Please always keep attention on your project (module) issues, always work on and update them regular. You are the maintainer.
https://www.drupal.org/project/issues/views_inject?categories=All

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community

Good work!
There is not any security issue into the code.

Nice tests also!
* Just keep in mind to use for tests only PHP version equal or greater than PHP7.

Mirroar’s picture

Mirroar commented

Thanks everybody for your valuable feedback! The addition of tests especially helped the project's stability, which is great because I was meaning to learn more about testing in Drupal anyway.

I just fixed the last of the mentioned issues and pushed a tag for a release candidate so people can start using that.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Needs review
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Mirroar’s picture

Mirroar commented

I don't want to sound impatient, but I'd like to know if there is anything I can do to move this along? I'd love to release 8.x-1.1 (Ideally with security coverage) so 8.x-1.0 no longer shows up as "Recommended by the project’s maintainer".

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The status was already changed to Reviewed & tested by the community, but then reverted to Needs review. I take there was a reason to review the application, but that should be asked to the user who changed back the status.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the contribution!

I was need more time to check everything in details, and yes, now the code is OK.
The status is updated.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.