In content_lock_entity_predelete() we are trying to fetch the lock but the function fetchLock() have parameters in wrong sequence.
It should have been
$data = $lock_service->fetchLock($entity_id, $entity->language()->getId(), NULL, $entity_type);
as per the fetchLock() function.

CommentFileSizeAuthor
#2 wrong_parameter-3063589-2.patch514 bytessergiu stici

Issue fork content_lock-3063589

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gulab.bisht created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new wrong_parameter-3063589-2.patch514 bytes

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: wrong_parameter-3063589-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ryankavalsky’s picture

ryankavalsky commented

I'm not experiencing this issue w/ 8.x-1.0-alpha8.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.0-alpha8 » 8.x-2.x-dev
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Needs steps to reproduce

@Sergiu Stici could you provide the steps you take to get this issue?

smustgrave opened merge request !33

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: -Needs steps to reproduce

Not seeing an issue during delete but 100% appears the parameters are in a wrong order. More surprised errors aren't appearing.

sokru’s picture

sokru commented
Status: Needs review » Reviewed & tested by the community

+1 for adding this.

alexpott made their first commit to this issue’s fork.

  • alexpott committed 7f8a2d36 on 8.x-2.x authored by smustgrave 
    Issue #3063589 by smustgrave, Sergiu Stici, gbisht: Wrong parameter...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

The whole pre delete thing needs a rewrite. But this issue is correct so merging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.