[D8] Activity Tracking

I am seeing few warnings in the PAReview checklist. You may want to resolve those :)

See, https://pareview.sh/pareview/https-git.drupal.org-project-activitytracki...

Hello,

There are still issues on https://pareview.sh/pareview/https-git.drupal.org-project-activitytracki...

All of them are about dependency injections. An example on how to fix them,

Instead of using:

$messenger= \Drupal::messenger();
$messenger->addMessage($message, 'statut');

First, use the namespace:

use Drupal\Core\Messenger\MessengerInterface;

Than add protected variable to your class:

protected $messenger;

In your constructor:

  public function __construct(MessengerInterface $messenger) {
    $this->messenger = $messenger;
  }

and then:

  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('messenger')
    );
  }

Then you can use

$this->messenger->addMessage($message, $message_status);

in your code.

I see a number of different injections necessary, you need to apply the same idea for all.

Thank you for your contribution.

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

Thanks for your contribution!

* activity_tracking_page_attachments_alter(): Instead of adding your CSS library here you should add it to the render array in your ActivityTracking form.
* Coding standards:

FILE: /home/klausi/workspace/drupal-8/modules/activitytracking/src/Form/activityTracking.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 17 | ERROR | Class name doesn't match filename; expected "class activityTracking"
--------------------------------------------------------------------------------------------

FILE: /home/klausi/workspace/drupal-8/modules/activitytracking/src/Services/activityTrackingService.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 14 | ERROR | Class name doesn't match filename; expected "class activityTrackingService"
-------------------------------------------------------------------------------------------------------

* Instead of accessing $_SERVER you should use $this->request->headers->get('User-Agent').
* activity_tracking_schema(): entity type is missing? What if a bundle name is the same between entity types?

Otherwise looks good to me, did not see any security issues.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

You need to edit your project and opt into security advisory coverage.

Your project is too young (3 days old), I think you can only opt into coverage after some time has passed. Please try again in 2 weeks!