Closed (fixed)
Project:
Request info
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Jun 2019 at 23:11 UTC
Updated:
22 Jun 2022 at 12:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alonaoneill commentedI uploaded the patch that adds hook_help file.
Thanks
Comment #3
avpadernoComment #4
alonaoneill commentedI uploaded new patch that adds different hook_help.
Can you check please?
Thanks
Comment #5
krina.addweb commented@alonaoneill, Thanks for the patch, I reviewed it using coding standards & attached my suggested changes in attached s.s could you please review it & share your valuable feedback for the same.
Comment #6
alonaoneill commentedI uploaded the patch that removes Usage part, as it's not helpfull since it gives you configuration info, that was already done at that point.
Comment #7
alonaoneill commentedAdded wrong one by mistake.
Comment #8
Willtg commentedIt looks like the info file changes were added to this patch that need to be removed.
Comment #9
alonaoneill commentedMade changes!
Comment #10
Willtg commented.
Comment #11
Willtg commentedPatch tested with STM and it worked fine. Adding a screenshot below for confirmation.
Code looks good marking RTBC!
Comment #12
fagothis does not look right.
Comment #13
avpadernoThere is a spelling error in the help message; the punctuation needs to be changed too. A better message would be similar to the following one.
I cannot say whether HTTP headers are followed is correct, as I cannot understand what the phrase means in this context. I would use a more explicit phrase.
The Add a link to the Drupal.org project. comment describes what is already clear in the code. Code comments should be used to describe something about the code that reading the code doesn't make clear.
The project page is only one. The message should read as Visit the Request info project page for more information.
Comment #14
avpadernoI also moved the
useline, which should come after the @file comment, and referred to the project as Request Info, which is the module name since the patch in #3025863: Capitalize the name of the module in .info.yml file has been committed.Comment #16
golubovicm commentedThank you for contributing to this module.
This improvement will be available in the next official release.