Problem/Motivation

The details.html.twig templates have a summary_attributesvariable, but it isn't mentioned in the documentation block at the start of the template.

Proposed resolution

Mention summary_attributes in the docblock for all variants of details.html.twig:

  • core/modules/system/templates/details.html.twig
  • core/themes/classy/templates/form/details.html.twig
  • core/themes/seven/templates/details.html.twig
  • core/themes/stable/templates/form/details.html.twig
CommentFileSizeAuthor
#8 3062157-8.patch3.06 KBshubham.prakash
#7 3062157-7.patch793 bytesshubham.prakash
#6 details.html-13170339.patch795 bytesswetha kashetty
#4 details.html_.patch795 bytesswetha kashetty
#2 document-summary_attributes-in-details-templates-3062157-2.patch2.28 KBandrewmacpherson

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

andrewmacpherson commented
Status: Active » Needs review
StatusFileSize
new document-summary_attributes-in-details-templates-3062157-2.patch2.28 KB
idebr’s picture

idebr commented
Status: Needs review » Needs work

The summary_attributes should also be documented in core/themes/classy/templates/form/details.html.twig

swetha kashetty’s picture

swetha kashetty commented
Assigned: Unassigned » swetha kashetty
StatusFileSize
new details.html_.patch795 bytes

Added summary_attributes variable in core/themes/classy/templates/form/details.html.twig

swetha kashetty’s picture

swetha kashetty commented
Status: Needs work » Needs review
swetha kashetty’s picture

swetha kashetty commented
StatusFileSize
new details.html-13170339.patch795 bytes

Added the summary_attributes to core/themes/classy/templates/form/details.html.twig

shubham.prakash’s picture

shubham.prakash commented
Assigned: swetha kashetty » Unassigned
StatusFileSize
new 3062157-7.patch793 bytes

This patch will fix the issue.

shubham.prakash’s picture

shubham.prakash commented
StatusFileSize
new 3062157-8.patch3.06 KB

This patch includes all required changes to fix the issue.

andrewmacpherson’s picture

andrewmacpherson commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thanks. Patch #8 is great - all the details templates are covered.

  • lauriii committed 7cb3afd on 8.8.x 
    Issue #3062157 by swetha kashetty, shubham.prakash, andrewmacpherson:...

  • lauriii committed 72f23ed on 8.7.x 
    Issue #3062157 by swetha kashetty, shubham.prakash, andrewmacpherson:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Searched for details.html.twig and details-- files and these are the only instances I could find.

Committed 7cb3afd and pushed to 8.8.x. Since this changes only documentation, I also cherry-picked this to 8.7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.