Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new512 bytes

I uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!

Willtg’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency name-spacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on the module!

Willtg’s picture

Code looks good. The dependency name-spacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on the module!

joshua1234511’s picture

Tested the patch, Works for me.
Marking as RTBC

sjinnovation’s picture

Assigned: Unassigned » sjinnovation
Status: Reviewed & tested by the community » Fixed

Patch added to the next release.
Thank you all for the help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.