Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
distribution/profile
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2019 at 09:30 UTC
Updated:
28 Jun 2019 at 13:14 UTC
Jump to comment: Most recent
Comments
Comment #2
klausiThanks for you contribution!
* sm_dev_portal_theme.theme: all user facing strings must run through t() for translation. Same for header.html.twig.
Otherwise looks good to me, did not see any security issues.
Comment #3
kiranjyoth commentedHi klausi,
I have fixed the theme & template translation issues in this release version.
https://www.drupal.org/project/sm_dev_portal/releases/8.x-1.3
Thanks
Comment #4
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.