I'd like to extend updown to work for comments. I have a working implementation already but would like a bit of feedback before I submit a patch. Also, #305752: Don't hardcode use of 'node' is a prerequisite.
Two questions:
Should updown for comments be global or per content type? If it's per content type I think the only way to do a check is to node_load($comment->nid); in an implementation of hook_comment(). Is that acceptable?
What about outputting the widget? Just $comment->comment .= theme('updown_active_widget', $comment); in hook_comment() again or provide some larger configuration options?
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | updown.tgz | 5.33 KB | coltrane |
Comments
Comment #1
coltraneFor reference here is a working tarball of updown on comments. I'll roll and post patches based on feedback.
Comment #2
OneTwoTait commentedSo... does the version from Oct 13 work with comments?
I think it would have to be per content type rahter than global.
Comment #3
dmitrig01 commentedIt's in. Thanks for the suggestion.