While working on

#2876274: Renderer: deprecate mergeBubbleableMetadata() and addCacheableDependency()

I noticed this error

phpunit with the code coverage switch enabled is good at compiling and displaying coverage statistics.
The rule of thumb is that @coversDefaultClass etc should point to production code.

EntityTestListBuilder is a surrogate for the real class under test "EntitListBuilder".

/**
 * @coversDefaultClass \Drupal\entity_test\EntityTestListBuilder
 * @group Entity
 */
class EntityListBuilderTest extends UnitTestCase {
CommentFileSizeAuthor
#2 covers-3060716-2.patch571 bytesmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned
Issue summary: View changes
Issue tags: +Quickfix
StatusFileSize
new covers-3060716-2.patch571 bytes

here is the patch

martin107’s picture

martin107 commented
Status: Active » Needs review

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Trivial patch of the month :)

Still applies and still wrong in HEAD

martin107’s picture

martin107 commented

Hah, yes, three years ago I was in a mildly grumpy mood wondering why the autocomplete in my IDE was not working.

Thanks for the review.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

This is testing on an unsupported version of Drupal. Can someone make a new patch and get it testing on 9.5 or 10?

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Reviewed & tested by the community

Still runs on 9.5, thanks for requeuing @Abhijith S

xjm’s picture

xjm
she/her
Primary language English
commented

This gave me a laugh, one-line docs fix tagged "Quickfix" that has been bumped along with a correct patch since 2019 -- and still applies!

Giving @Lendude reviewer credit for rescuing this from obscurity even though we wouldn't normally give credit for a review on an issue like this. (And to @quietone for the same reason.)

  • xjm committed 48589c8 on 10.1.x 
    Issue #3060716 by martin107, Lendude, quietone: EntityListBuilderTest: @...

  • xjm committed facf805 on 10.0.x 
    Issue #3060716 by martin107, Lendude, quietone: EntityListBuilderTest: @...

  • xjm committed 43c4101 on 9.5.x 
    Issue #3060716 by martin107, Lendude, quietone: EntityListBuilderTest: @...

  • xjm committed 6da1527 on 9.4.x 
    Issue #3060716 by martin107, Lendude, quietone: EntityListBuilderTest: @...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 10.1.x, and cherry-picked to 10.0.x, 9.5.x, and 9.4.x as a patch-release-eligible docs bugfix. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.