oembed encode the video URL and add the provider URL to it
the providers not understand the parameters in the URL like '?background=1&mute=0' and skip it because the encode function
test urls ( the url passed to provider api )
- the defulte url
https://vimeo.com/api/oembed.json?url=https%3A//player.vimeo.com/video/3...
- with the decode
https://vimeo.com/api/oembed.json?url=https://player.vimeo.com/video/336...
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3060550-oembed-link-does-not-pass-url-parameter-to-provider-1.patch | 2.16 KB | firass.ziedan |
| #3 | 3060550-oembed-link-does-not-pass-url-parameter-to-provider.patch | 847 bytes | firass.ziedan |
| url-image-with-decode.png | 159.93 KB | firass.ziedan | |
| url-image-without-decode.png | 162.08 KB | firass.ziedan |
Comments
Comment #2
firass.ziedanComment #3
firass.ziedanComment #5
firass.ziedanComment #6
rajab natshahComment #8
catchGood find. Patch looks great.
Committed/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!
Comment #11
mfbThis change actually breaks things for me, as I need the query parameters to be URL-encoded in order for things to work. Created a followup issue: #3397558: OEmbed generates URLs with URL-decoded query string