Following on from #2804771: noreqnewpass|coder review|Drupal code standards missing, attached is a patch to fix code standards issues in the 8.x-1.x branch.

CommentFileSizeAuthor
#4 3060259-4.patch4.47 KBneslee canil pinto
#3 phpcs_AFTER_patch-2.txt5.83 KBandrewmacpherson
#3 phpcs_BEFORE_patch-2.txt6.23 KBandrewmacpherson
noreqnewpass_d8_code_standards.patch3.2 KBlogickal

Comments

logickal created an issue. See original summary.

logickal’s picture

logickal commented
Status: Active » Needs review
andrewmacpherson’s picture

andrewmacpherson commented
StatusFileSize
new phpcs_BEFORE_patch-2.txt6.23 KB
new phpcs_AFTER_patch-2.txt5.83 KB

There are many more still to fix. I've attached the output of phpcs --standard=Drupal,DrupalPractice before and after the patch in #2.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
StatusFileSize
new 3060259-4.patch4.47 KB

  • Neslee Canil Pinto committed ab62b78 on 8.x-1.x 
    Issue #3060259 by logickal, Neslee Canil Pinto, andrewmacpherson: Drupal...
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.