error in deprecation note on EntityInterface::link()

Please review

We need to update the corresponding @trigger_error() here

  /**
   * {@inheritdoc}
   */
  public function link($text = NULL, $rel = 'canonical', array $options = []) {
    @trigger_error("EntityInterface::link() is deprecated in Drupal 8.0.0 and will be removed in Drupal 9.0.0. EntityInterface::toLink() instead. Note, the default relationship for configuration entities changes from 'edit-form' to 'canonical'. See https://www.drupal.org/node/2614344", E_USER_DEPRECATED);
    return $this->toLink($text, $rel, $options)->toString();
  }

too.

Please review.

Updated patch added with an interdiff.

Updated patch with an interdiff.

Looks like changes was added to improper place. According to the task description need to update deprecated message for link() method, but in a patch the message ancidentally have been updated for url() method.

Updated patch.

Committed and pushed 1546b4b85a to 8.8.x and 0dbceaa4eb to 8.7.x. Thanks!

We have a thing about not using the word Please so I've remove that from the deprecation message on commit. I've checked that the CR also agrees with this advice. One thing that complicates this a bit is that there times when calling toString() is no longer needed at the point you were calling ::link() but it is the most direct replacement so I guess this is fine.

Also fixed the @see mentioned in the issue summary.

diff --git a/core/lib/Drupal/Core/Entity/EntityInterface.php b/core/lib/Drupal/Core/Entity/EntityInterface.php
index 8f88b39789..e2b5b8ef9b 100644
--- a/core/lib/Drupal/Core/Entity/EntityInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityInterface.php
@@ -189,10 +189,10 @@ public function url($rel = 'canonical', $options = []);
    *   An HTML string containing a link to the entity.
    *
    * @deprecated in Drupal 8.0.0, intended to be removed in Drupal 9.0.0
-   *   Please use \Drupal\Core\EntityInterface::toLink()->toString() instead.
+   *   Use \Drupal\Core\EntityInterface::toLink()->toString() instead.
    *
    * @see https://www.drupal.org/node/2614344
-   * @see \Drupal\Core\Entity\EntityInterface::toLink
+   * @see \Drupal\Core\Entity\EntityInterface::toLink()
    */
   public function link($text = NULL, $rel = 'canonical', array $options = []);