Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
5 Jun 2019 at 06:52 UTC
Updated:
2 Jul 2019 at 22:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vishal.sirsodiya commentedComment #3
avpadernoThank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.
If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.
Comment #4
avpadernoThe repository is using wrong branch names. See Release naming conventions, which explains which are the correct branch and tag names.
Comment #5
vishal.sirsodiya commentedI have resolved all issues and change branch name, new branch name is 7.x-1.x-dev (follow below links).
https://www.drupal.org/node/1015226
New git URL :-
https://git.drupalcode.org/project/node_email/tree/7.x-1.x-dev/
Comment #6
klausiComment #7
klausiThanks for your contribution!
* node_email_form_alter(): this add a submit handler to every single form in Drupal. You should only add it for node forms, right?
* node_email_mail_alter(): why do you need to set these special mail headers? Please add a comment in code.
* _node_email_handler(): the arg() call should be removed when you just add your submit handler when necessary.
I don't see security issues otherwise. We have more than 100 lines of code here, so I think we can do a full approval.
Comment #8
vishal.sirsodiya commentedThanks for review.
* Not every single form, this handler for only node forms like ndd/add/news or node/{nid}/edit.
* special mail header for preparing mail subject and body.
* arg() use for check URL arguments. because "_node_email_handler" add only in content type forms.
Please review again I have added some code for configuration.
Comment #9
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.