Problem/Motivation

WebDriverTestBase is a FunctionalJavascript test.

The namespace of tests should be \Drupal\Tests\$extension\$suite_type and tests must be within a tests/src/$suite_type directory.

PHPUnit file structure, namespace, and required metadata

PHPUnit-based: Generally, the other suites must be within a tests/src/$suite_type directory. These tests will have a namespace of \Drupal\Tests\$extension\$suite_type. Note that there are exceptions to this naming scheme, illustrated below.

Proposed resolution

Change the namespace of RestUITest to \Drupal\Tests\restui\FunctionalJavascript and change directory to tests/src/FunctionalJavascript.

CommentFileSizeAuthor
#2 restui-3059446-2.patch572 byteskrzysztof domański

Comments

Krzysztof Domański created an issue. See original summary.

krzysztof domański’s picture

Status: Active » Needs review
StatusFileSize
new572 bytes
krzysztof domański’s picture

Issue summary: View changes
wim leers’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +API-First Initiative

👍🙏

clemens.tolboom’s picture

Status: Reviewed & tested by the community » Fixed

TNX!

clemens.tolboom’s picture

Hmmm ... got the commit credits wrong. @Wim Leers sorry :-/

krzysztof domański’s picture

The name of the directory should be changed to FunctionalJavascript. It looks like the test was duplicated by mistake.

tests/src/Functional/RestUITest.php
tests/src/FunctionalJavascript/RestUITest.php

https://git.drupalcode.org/project/restui/commit/018ed4b

clemens.tolboom’s picture

I forgot to rm the moved file. Somehow git apply did not 'moved it'.

git status
On branch 8.x-1.x
Your branch is up to date with 'origin/8.x-1.x'.

Changes not staged for commit:
(use "git add/rm ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

deleted: tests/src/Functional/RestUITest.php

no changes added to commit (use "git add" and/or "git commit -a")
$ git rm tests/src/Functional/RestUITest.php

wim leers’s picture

#7: don't worry about me :)

#10: git apply -3v PATCH FTW :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.