Problem/Motivation

\Drupal\Core\Composer\Composer::$packageToCleanup has been kept up-to-date. Let's update it.

Proposed resolution

Update the list

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#11 3057462-11.patch3.36 KBmile23
#4 3057462-4.patch3.36 KBalexpott
#4 2-4-interdiff.txt1.03 KBalexpott
#2 3057462-2.patch3.3 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3057462-2.patch3.3 KB

Here we go.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work

Diggit. :-)

  1. +++ b/core/lib/Drupal/Core/Composer/Composer.php
@@ -26,31 +27,42 @@ class Composer {
     'masterminds/html5' => ['test'],

    Has a bin. 

  2. +++ b/core/lib/Drupal/Core/Composer/Composer.php
@@ -26,31 +27,42 @@ class Composer {
+    'phpspec/prophecy' => ['tests'],

    Has spec. 

  3. +++ b/core/lib/Drupal/Core/Composer/Composer.php
@@ -63,6 +75,7 @@ class Composer {
     // 'symfony/event-dispatcher' => ['Tests'],

    How about a @todo for https://www.drupal.org/project/drupal/issues/3055040 

  4. +++ b/core/lib/Drupal/Core/Composer/Composer.php
@@ -71,7 +84,11 @@ class Composer {
     'symfony/validator' => ['Tests', 'Resources'],

    Also has a Test folder.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2-4-interdiff.txt1.03 KB
new 3057462-4.patch3.36 KB

Thanks for the review

  1. Fixed
  2. Fixed and added more
  3. Added note to issue to fix this and remove the @see - seems more effective than an @todo
  4. Test is included in the classmap so I don't think we should remove that.
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

LGTM.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

We might work backwards from here and do this for 8.7.x, as well.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

+1

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3057462-4.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community

Vimeo was down #3059022: If Vimeo is down our tests break

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

lol. there we go again, testing that the internet works. ;)

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3057462-11.patch3.36 KB

Reroll after #3055040: Roll AbstractEventDispatcherTest into ContainerAwareEventDispatcherTest

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Setting back to RTBC after reroll and test passes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

As per #12

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed f4bf1ae and pushed to 8.8.x. Thanks!

  • catch committed f4bf1ae on 8.8.x 
    Issue #3057462 by alexpott, Mile23: Add missing packages to \Drupal\Core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.