Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#6 beforeafter.png187.98 KBswatichouhan012
#4 before_after-info-3057105-4.patch426 bytesalonaoneill
#2 before_after-info-3057105-2.patch427 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new before_after-info-3057105-2.patch427 bytes

I uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!

L2G2’s picture

L2G2
she/her
commented
Status: Needs review » Needs work

There is a typo in the description.
The word formate should be format.

alonaoneill’s picture

alonaoneill commented
Status: Needs work » Needs review
StatusFileSize
new before_after-info-3057105-4.patch426 bytes

Fixed it!
Back for review!

Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency name-spacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on the module!

swatichouhan012’s picture

swatichouhan012 commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new beforeafter.png187.98 KB

Thanks for apply patch i fixed above mentioned issue in new version.

swatichouhan012’s picture

swatichouhan012 commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.