EVA (short for Email Validator) is a validation tool aimed at keeping your platforms free from fake or disposable email accounts.

Your Drupal system is now able to keep those fake email accounts at bay.

Project link

https://www.drupal.org/project/email_validator

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/email_validator.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-email_validato...

Comments

sbit created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

Remember to change status, when the project is ready to be reviewed. The current status is telling users not to review it.

tiagof’s picture

tiagof commented
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Thanks for your contribution!

manual review:
* yml settings: config schema is missing, see https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...
* EVA::isValid(): you are calling the parent method but you are not using the result? Shouldn't you return false if the email is not valid per RFC?

Otherwise looks good to me!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.