Remove dead code in NodeTypeForm::actions()

Nice find!

Attached patch adds test coverage. Interestingly it did not fail because 'Delete' partially matches 'Delete content type'.

I suggest we move the question "Should the entity type be mentioned on the save/delete button?" to a followup issue and keep this scoped to a simple bug fix. The intended UX was developed a long time ago (see #111715: Convert node/content types into configuration where the current code was implemented back in 2013).

+1: Patch & test look good to me.

Reupload of #4 to reduce testbot clutter.

Let's remove the line instead. No changes to the UI, no changes to tests, and consistent with the very similar vocabulary edit screen.

Sounds logical. Updated according to last comment.

1. Updated the issue summary with the proposed resolution in #25
2. Patch applies cleanly to 8.8.x, RTBC assuming the tests come back green.

Changing the title to reflect what's happening here.

Committed and pushed 8ca1b5a7c5 to 8.8.x and 9c815fd316 to 8.7.x. Thanks!

As this code is not used I've backported this to 8.7.x to keep the branches in-sync. I spent a bit of time trying to find an issue about standardising these buttons but then realised that even if this the new standard would be for this button to read 'Delete content type' then we'd need to handle that change correctly. And this code is still dead. So removing it now is fine even if we decided to change the button text at a later date.

It'd be great if someone could try to find that issue about standardising button texts because I think we probably should open a follow-up to completely remove the method override here.