https://git.drupalcode.org/project/dc_ajax_add_cart/blob/8.x-1.x/src/Plu...
There is the method settingsForm() does nothing new.
I think he is not needed

CommentFileSizeAuthor
#9 dc_ajax_add_cart-not-needed-settingsForm-3056586-9.patch1.89 KBlukasss
#8 dc_ajax_add_cart-not-needed-settingsForm-3056586-8.patch1.4 KBlukasss
#4 dc_ajax_add_cart-not-needed-settingsForm-3056586-4.patch1.09 KBlukasss

Comments

lukasss created an issue. See original summary.

lukasss’s picture

lukasss commented
Title: Extra method settingsForm() » Not needed method settingsForm()
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Patches are welcome.

lukasss’s picture

lukasss commented
StatusFileSize
new dc_ajax_add_cart-not-needed-settingsForm-3056586-4.patch1.09 KB
lukasss’s picture

lukasss commented
Status: Active » Needs review
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs review » Needs work
ivnish’s picture

ivnish
he/him
commented

subhojit777, why do you set "Needs work"?

lukasss’s picture

lukasss commented
StatusFileSize
new dc_ajax_add_cart-not-needed-settingsForm-3056586-8.patch1.4 KB

fix

lukasss’s picture

lukasss commented
StatusFileSize
new dc_ajax_add_cart-not-needed-settingsForm-3056586-9.patch1.89 KB

Not the right way to trait in the test

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Re #7:

Its the same reason due to the problem that patch in #9 fixes. I thought it would be obvious, and therefore didn't mention it.

I haven't updated this module as per the latest developments in Commerce core. And I think the test fails are due to the breaking changes. I know it is too much to ask for, but could you look into it?

Re #9

Not the right way to trait in the test

What do you mean?

lukasss’s picture

lukasss commented

Yes, we need to rewrite all the tests.