API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Cache%21D...

  /**
   * The settings array.
   *
   * @var \Drupal\Core\Site\Settings
   */
  protected $settings;

It's not an array.

This crops up in a few other classes too, so should fix all in one go.

A better wording would be what FileSystem has:

  /**
   * The site settings.
   *
   * @var \Drupal\Core\Site\Settings
   */
  protected $settings;
CommentFileSizeAuthor
#6 interdiff-3056414-2-6.txt1.27 KByogeshmpawar
#6 3056414-6.patch1.72 KByogeshmpawar
#2 inaccurate_property_docs-3056414-2.patch979 bytesR.shaikh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

R.shaikh’s picture

R.shaikh CreditAttribution: R.shaikh at Asentech LLC commented
FileSize
inaccurate_property_docs-3056414-2.patch979 bytes

@joachim... i have made changes as you suggested. please review it.

R.shaikh’s picture

R.shaikh CreditAttribution: R.shaikh at Asentech LLC commented
Status: Active » Needs review
John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Needs review » Needs work

Hi @R.shaikh. Thank you working on the documentation.

The patch applies cleanly.

After applying there are two more places in the comments that need updating.

  • Drupal\Core\Cache\CacheFactory::__construct() line 40
  • Drupal\Core\Cache\DatabaseBackendFactory::__construct() line 39

These are both parameter comments that set the property of the classes.

I've set this back to needs work, but it looks like this issue will be ready soon.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
3056414-6.patch1.72 KB
interdiff-3056414-2-6.txt1.27 KB

Comments addressed in #4 & added an interdiff as well.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed d7183eeaca to 8.8.x and 878f874af6 to 8.7.x. Thanks!

Backported to 8.7.x as a docs only fix.

  • alexpott committed d7183ee on 8.8.x 
    Issue #3056414 by yogeshmpawar, R.shaikh, joachim, John Cook: inaccurate...

  • alexpott committed 878f874 on 8.7.x 
    Issue #3056414 by yogeshmpawar, R.shaikh, joachim, John Cook: inaccurate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.