NodeRevisionDeleteForm has a description: "Provides a form for reverting a node revision." which is not correct, as such functionality is provided by the NodeRevisionRevertForm.

CommentFileSizeAuthor
#2 3056348-2-fix-code-comment.patch491 bytespasqualle

Comments

Pasqualle created an issue. See original summary.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Active » Needs review
StatusFileSize
new 3056348-2-fix-code-comment.patch491 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3056348-2-fix-code-comment.patch, failed testing. View results

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review
idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8425a0918c to 8.8.x and 2910bb21f2 to 8.7.x. Thanks!

  • alexpott committed 8425a09 on 8.8.x 
    Issue #3056348 by Pasqualle: Wrong code comment in...

  • alexpott committed 2910bb2 on 8.7.x 
    Issue #3056348 by Pasqualle: Wrong code comment in...
niklan’s picture

niklan
Primary language Russian
Location Russia, Perm
commented
Title: Wrong code comment in NodeRevisionRevertForm » Wrong code comment in NodeRevisionDeleteForm

I changed title since it is misleading. Wrong comment in NodeRevisionDeleteForm according to patch, not in NodeRevisionRevertForm.

So, I think it must be also changed in changelog.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.