Create an action to unpublish a node.

Thank you
Vishal

Comments

vishalkhialani created an issue. See original summary.

rensingh99’s picture

rensingh99 commented
Assigned: vishalkhialani » rensingh99

I'll work on this.

rensingh99’s picture

rensingh99 commented

I have pushed the code, Please do a code review.

neeravbm’s picture

neeravbm commented

Hi Ren,

1) Please improve on the validate function its will cause a infinite while loop.
2) Also you are taking a int value please improve to allow an entity object too.
3) Please use coder and improve on the drupal standards.

Thank you,
Neerav.

rensingh99’s picture

rensingh99 commented

I have worked for #2, Please do a code review.

rensingh99’s picture

rensingh99 commented

I have worked for above changes as per requirement, Please do a code review.

  • rensingh99 authored 1216cf6 on 8.x-1.x 
    Issue #3055964 by vishalkhialani, rensingh99: unpublish a node
  • rensingh99 authored 599425f on 8.x-1.x
    Issue #3055964 by rensingh99, vishalkhialani, neeravbm: unpublish a node
  • rensingh99 authored 5d24c66 on 8.x-1.x
    Issue #3055964 by rensingh99, vishalkhialani, neeravbm: unpublish a node
  • rensingh99 authored ae448bf on 8.x-1.x
    Issue #3055964 by rensingh99, vishalkhialani, neeravbm: unpublish a node
  • rensingh99 authored fafeea5 on 8.x-1.x
    Issue #3055964 by rensingh99, vishalkhialani, neeravbm: unpublish a node
neeravbm’s picture

neeravbm commented
Status: Active » Fixed

I confirm its working now and the code has been improved.

Thank you,
Neerav

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.