In submitForm() there is this piece of code:

    if ($des == '') {
      $des = $op;
    } else {
      $des = $op . ': ' . $des;
    }

The variable "$des" is not defined so it can not have a value.

CommentFileSizeAuthor
#7 3055839-7.patch791 bytesrpayanm
#5 3055839-5.patch646 bytesrpayanm

Comments

Ice-D created an issue. See original summary.

Ice-D’s picture

Ice-D commented
Issue summary: View changes
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Would you be up to create a patch for this? :)

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Issue tags: +Novice
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3055839-5.patch646 bytes

I removed this piece of code, because the $des var is not use.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Needs work

Good catch, but then $op seems also unused a few lines above.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 3055839-7.patch791 bytes

Ups :)

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Category: Bug report » Task
Status: Needs review » Fixed

Committed Thanks.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

You should have added attribution as described in https://www.drupal.org/node/1146430